fix(form-core): Fix setBy/getBy not handling arrays properly#1517
Merged
Balastrong merged 2 commits intoTanStack:mainfrom May 22, 2025
Merged
fix(form-core): Fix setBy/getBy not handling arrays properly#1517Balastrong merged 2 commits intoTanStack:mainfrom
setBy/getBy not handling arrays properly#1517Balastrong merged 2 commits intoTanStack:mainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit a4d992a.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 31 31
Lines 1417 1417
Branches 362 362
=======================================
Hits 1263 1263
Misses 137 137
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LeCarbonator
changed the title
setBy/getBy not handling arrays properlysetBy/getBy not handling arrays properly
Balastrong
approved these changes
May 19, 2025
|
LGTM 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1488
During parsing of the field name, multi-dimensional arrays (or names starting with an array access) were wrongly parsed in functions using
makePathArrayinternally.The side effects of this are listed in the linked issue, but to summarize, it wrongly interpreted array access as an object key, and that apparently lead to JavaScript silently converting the array into an object (classic ...)
The reason were mostly the regular expressions used to parse the field name, so test cases have been added and the function has been refactored.
Before
With PR
There is now a lookahead used to avoid mismatches with subsequent numbers. Benchmarks didn't show a significant drop in performance, but let me know if you notice something suspicious.